Modify observer_set to only accept and pass const ref arguments
#4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit dd668adPull Request 4768: Results Test Case Results
Last updated: 2024-10-27 11:36:58 UTC |
clemahieu
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids copying parameters when notifying observers.
It's the first part of the refactoring, the second will be dropping redundant
const &qualifications from observer set events, eg:nano::observer_set<processed_batch_t const &> batch_processed;to justnano::observer_set<processed_batch_t> batch_processed;should be fine now, the batch will be passed by reference by default. I'll do this refactoring after bounded backlog changes as it will mess a lot of existing commits.